Add GetCacheKeys() method to allow for partial key removal operations #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dictionary to maintain cache keys
|
Hi thanks for this. The challenge with accepting this is that I imagine all operations against the cache will now take around twice as long because there are effectively 2 caches to maintain. There are some benchmarks in the project that could be used to demonstrate this. In addition if an item in the cache expires due to age I don't think it will be removed from the list of keys uoi added? So potentialy the list of cache keys could grow forever? Based on the current design of your implementation I don't think it would be possible to accept a PR like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read numerous requests to have a better mechanism to enumerate through keys that are stored in cache. This makes it very convenient to expire an entire set of cached items based on a prefixing pattern. While I understand there are various other ways to achieve this (like using cancellation tokens, or multiple caches) having access to a dictionary of keys makes for a very simple implementation.
Internally this maintains a ConcurrentDictionary with all of the cache keys, and a metadata object about each cached item. When calling
GetCacheKeys()you get a copy of the key dictionary at a point in time. It's fully possible that a separate process changes the dictionary after the copy is taken. If the caller needs to prevent the dictionary from being modified while consuming the key dictionary that locking could be added external of LazyCache. For many use cases that level of control wouldn't be needed.I've also added tests to demonstrate the dictionary working properly.